Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix privilege for the view in the CTE and wrong error handle #53556

Merged
merged 8 commits into from
May 28, 2024
Merged

planner: fix privilege for the view in the CTE and wrong error handle #53556

merged 8 commits into from
May 28, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 27, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #49721

Problem Summary:

What changed and how does it work?

1、error handle is wrong. Any error will return PrivilegeErro
2、RequestVerificationWithUser meet empty user, it should return true.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2024
@codecov Codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.4852%. Comparing base (68d1295) to head (13a68a0).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53556        +/-   ##
================================================
+ Coverage   72.4357%   74.4852%   +2.0494%     
================================================
  Files          1507       1507                
  Lines        430587     431283       +696     
================================================
+ Hits         311899     321242      +9343     
+ Misses        99369      90161      -9208     
- Partials      19319      19880       +561
Flag Coverage Δ
integration 49.1745% <40.0000%> (?)
unit 71.4286% <100.0000%> (+0.0183%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4402% <ø> (+9.0158%) ⬆️

@hawkingrei
planner: fix privilege for the view in the CTE
763a086 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
statistics: make sure that get max table id
bf111b1 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
bb08b2c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
efd3807 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title planner: fix privilege for the view in the CTE planner: fix privilege for the view in the CTE and wrong error handle May 28, 2024
@hawkingrei
*
8aef889 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
903e20f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
cddb822 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*
13a68a0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-28 08:28:41.851947034 +0000 UTC m=+2765075.609082607: ☑️ agreed by qw4990.
  • 2024-05-28 08:30:13.845124968 +0000 UTC m=+2765167.602260536: ☑️ agreed by xhebox.

@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit d2d1257 into pingcap:master May 28, 2024
23 checks passed
@hawkingrei hawkingrei deleted the 49721 branch May 28, 2024 09:22
@hawkingrei hawkingrei restored the 49721 branch May 28, 2024 09:23
@hawkingrei
Copy link
Member Author

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1

@hawkingrei
Copy link
Member Author

/cherrypick release-6.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 28, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#53556
076c097 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #53626.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2024
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 28, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#53556
4b11a71 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #53627.

In response to this:

/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #53628.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 28, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#53556
5f72d2e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2024
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 28, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#53556
d90b058 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #53629.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2024
@ti-chi-bot
planner: fix privilege for the view in the CTE and wrong error handle (…
bf71326 
…#53556) (#53628)

close #49721
ti-chi-bot bot pushed a commit that referenced this pull request Jun 5, 2024
@ti-chi-bot
planner: fix privilege for the view in the CTE and wrong error handle (…
ca9f24a 
…#53556) (#53627)

close #49721
@hawkingrei hawkingrei deleted the 49721 branch July 4, 2024 08:15
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2024
@ti-chi-bot
planner: fix privilege for the view in the CTE and wrong error handle (…
61944be 
…#53556) (#53629)

close #49721
hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Nov 6, 2024
@hawkingrei
This is an automated cherry-pick of pingcap#53556
8fd7033 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 12, 2024
@ti-chi-bot
planner: fix privilege for the view in the CTE and wrong error handle (…
c1d0ada 
…#53556) (#53626)

close #49721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@hawkingrei @ti-chi-bot @xhebox @qw4990 @winoros